Fix sporadic missing pants on initial spawn after character selection#152
Open
DispersiaRoleplay wants to merge 2 commits intoVORPCORE:mainfrom
Open
Fix sporadic missing pants on initial spawn after character selection#152DispersiaRoleplay wants to merge 2 commits intoVORPCORE:mainfrom
DispersiaRoleplay wants to merge 2 commits intoVORPCORE:mainfrom
Conversation
Fixes sporadic "no pants on spawn" until clothing menu "wear all" is used.
Fix sporadic missing pants on initial spawn after character selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a sporadic issue where the player spawns without pants until the clothing menu "wear all" option is used.
Pull request template
Important
Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.
Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.
Type of change
Motive for This Pull Request
Some players would occasionally spawn without pants after selecting a character.
The issue resolved itself once the clothing menu was opened and "wear all" was applied, indicating that the pants component was not being re-applied during the initial spawn flow.
Provide a brief explanation of why these changes are being proposed and what they aim to achieve.
This change ensures the pants component is explicitly re-applied to the ped after a boots wearable state change (
tuck), matching the behavior of the clothing menu "wear all" action and preventing incomplete outfit application on spawn.Explain the necessity of these changes and how they will impact the framework or its users.
Without this fix, affected players may spawn with incomplete outfits, breaking immersion and causing confusion.
The change is minimal, non-breaking, and only re-applies an already loaded clothing component, with no impact on performance or existing logic.
Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Also, list any relevant details for your test configuration.
Test steps:
vorp_character.Notes if any
This PR adds a single

ApplyShopItemToPedcall and does not alter existing logic or introduce refactors.