translation: remove some strings that may be potentially machine-gene… #528
Conversation
|
OK nvm, fastlane/ isn't AI generated, it's just copied from the existing strings |
|
It will fail checks until #526 is up |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
=========================================
Coverage 95.27% 95.27%
Complexity 871 871
=========================================
Files 123 123
Lines 2627 2627
Branches 194 194
=========================================
Hits 2503 2503
Misses 44 44
Partials 80 80 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes potentially machine-generated translation strings across Fastlane metadata and Android resource files.
- Deleted Italian, French, Spanish, German, and Bulgarian short/full descriptions in Fastlane metadata
- Removed legacy or redundant string resources (
filter_ssid_title,group_by_virtual,theme_system, etc.) from various locale XML files
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fastlane/metadata/android/**/short_description.txt | Cleared localized short descriptions |
| fastlane/metadata/android/**/full_description.txt | Cleared localized full descriptions |
| app/src/main/res/values-zh-rTW/strings.xml | Removed filter_ssid_title entry |
| app/src/main/res/values-uk/strings.xml | Removed filter_ssid_title entry |
| app/src/main/res/values-tr/strings.xml | Removed filter_ssid_title and filter_wifi_band_title |
| app/src/main/res/values-ru/strings.xml | Removed group_by_virtual, theme_system, keep_screen_on_title, and filter_ssid_title |
| app/src/main/res/values-nl/strings.xml | Removed filter_ssid_title entry |
| app/src/main/res/values-ja/strings.xml | Removed filter_ssid_title entry |
| app/src/main/res/values-it/strings.xml | Removed group_by_virtual and filter_ssid_title |
| app/src/main/res/values-el/strings.xml | Removed filter_ssid_title entry |
| app/src/main/res/values-de/strings.xml | Removed filter_ssid_title entry |
| app/src/main/res/values-bg/strings.xml | Removed group_by_virtual and filter_ssid_title |
Comments suppressed due to low confidence (3)
fastlane/metadata/android/it/short_description.txt:1
- Emptying the file may cause Fastlane to error if it expects non-empty descriptions; consider deleting the file entirely or updating Fastlane config to skip empty metadata.
-Ottimizza la tua rete Wi-Fi
app/src/main/res/values-zh-rTW/strings.xml:124
- [nitpick] Removing this key in many locales but not in the base/default resources may lead to missing translations or unintended fallbacks; ensure consistency across all resource sets.
- <string name="filter_ssid_title">"SSID (區分大小寫)"</string>
app/src/main/res/values-ru/strings.xml:71
- This key is removed here but remains in other locales; if the feature is deprecated, please remove the reference across all languages or update code to avoid NPEs.
- <string name="group_by_virtual">"Virtual"</string>
Please do not remove fastlane short and full description. The only thing that is missing a Features list in each language. |
| <string name="filter_reset">"Sıfırla"</string> | ||
| <string name="filter_apply">"Uygula"</string> | ||
| <string name="filter_ssid_title">"SSID (harfe duyarlı)"</string> | ||
| <string name="filter_wifi_band_title">"Wi-Fi Bandı"</string> |
There was a problem hiding this comment.
What is the reason to remove this?
It is translated and not machine-generated
|
I'm probably gonna separate this into multiple PRs |
Are you sure? You're actively hiding information for these languages right now, people that know English may not see this. That description isn't very useful otherwise. There's also less chance someone will look into translating it if it seems translated but is undone |
| @@ -1 +0,0 @@ | |||
| Оптимизирайте своята Wi-Fi мрежа, като проверите състоянието на Wi-Fi мрежата, силата на сигнала и идентифицирате пренаселените канали, използвайки WiFiAnalyzer с отворен код за Android No newline at end of file | |||
There was a problem hiding this comment.
Оптимизирайте своята Wi-Fi мрежа, като проверите състоянието на Wi-Fi мрежата, силата на сигнала и идентифицирате пренаселените канали, използвайки WiFiAnalyzer с отворен код за Android
Функции:
- Идентифициране на близки точки за достъп
- Графика на силата на сигнала по канали
- Графика на силата на сигнала на точките за достъп във времето
- Анализ на Wi-Fi мрежи за оценка на каналите
- HT/VHT откриване - 40/80/160/320 MHz (Изисква хардуерна/софтуерна поддръжка)
- 2.4 GHz, 5 GHz и 6 GHz Wi-Fi ленти (Изисква хардуерна/софтуерна поддръжка)
- Пълен или компактен изглед на точките за достъп
- Оценка на разстоянието до точките за достъп
- Експортиране на детайли за точките за достъп
- Тъмна, светла и системна тема
- Пауза/възобновяване на сканирането
- Налични филтри: Wi-Fi лента, сила на сигнала, сигурност и SSID
- Търсене в база данни на производители/OUI
| @@ -1 +0,0 @@ | |||
| Optimiza tu red Wi-Fi, mediante la comprobación de estado de red, intensidad de señal e identificación de los canales llenos usando la aplicación de código abierto WiFiAnalyzer para Android No newline at end of file | |||
There was a problem hiding this comment.
Optimiza tu red Wi-Fi, mediante la comprobación de estado de red, intensidad de señal e identificación de los canales llenos usando la aplicación de código abierto WiFiAnalyzer para Android
Funciones:
- Identifica los puntos de acceso cercanos
- Grafica la intensidad de la señal por canales
- Grafica la intensidad de la señal de los puntos de acceso a lo largo del tiempo
- Analiza las redes Wi-Fi para calificar los canales
- Detección HT/VHT - 40/80/160/320 MHz (requiere soporte de hardware/software)
- Bandas Wi-Fi de 2.4 GHz, 5 GHz y 6 GHz (requiere soporte de hardware/software)
- Vista de puntos de acceso completa o compacta
- Distancia estimada a los puntos de acceso
- Exporta los detalles de los puntos de acceso
- Tema oscuro, claro y del sistema disponible
- Pausar/reanudar el escaneo
- Filtros disponibles: banda Wi-Fi, intensidad de la señal, seguridad y SSID
- Búsqueda en la base de datos de fabricantes/OUI
Yes A better solution would be to add a list of missing features. Here are a few examples: |
|
@VREMSoftwareDevelopment are those AI? we do have an AI translation feature in Weblate that we can try, I believe. That way it is easier to tag them as needing editing |
|
e.g. |
|
I marked PT-BR as needing editing to see if it got at least a respectable translation but... hm... it... definitely not
|
Yes, please do it |
…rated this is hard to find out now because we're using git blame basically, but SSID (case-sensitive) is unmodified in most, and there no next commits some of it may have been lost to some 'translation cleanup' commits
|
I'm just gonna mark these as needing editing in Weblate so a next translator can have a look into it right away. |
Thanks |
2 participants
…rated
this is hard to find out now because we're using git blame basically, but SSID (case-sensitive) is unmodified in most, and there no next commits
some of it may have been lost to some 'translation cleanup' commits
there's a lot in fastlane/ though.