Fix build with -fsingle-precision-constant#98
Open
falkTX wants to merge 1 commit intoValleyAudio:mainfrom
Open
Fix build with -fsingle-precision-constant#98falkTX wants to merge 1 commit intoValleyAudio:mainfrom
falkTX wants to merge 1 commit intoValleyAudio:mainfrom
Conversation
Signed-off-by: falkTX <falktx@falktx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-fsingle-precision-constantcompiler flag is used to get some performance benefits for systems where 32bit float math is faster than 64bit, it automatically converts all staticly typed doubles into floats which reduces the chance of "double promotion".This can generate some conflicts at times with templated functions, and is the case for ValleyAudio modules, with the error being:
The fix is straight forward, we can just specify the function template type, which is more verbose but doesn't hurt anything.