Skip to content

Conversation

@elnurvl
Copy link

@elnurvl elnurvl commented May 20, 2025

HUD message color variables are left uninitialized during the first few frames, causing a crash in the debug build of client.dll.

I replaced the duplicated initialization logic with a single line placed before the branching, since the variables are used regardless of the conditions anyway.

Fixes #1536

Initialize destRed, destGreen, destBlue variables
@dtugend
Copy link
Contributor

dtugend commented May 21, 2025

We already proposed similar changes and they got merged with #1539, however they were reverted them with 0fc8913:

@elnurvl
Copy link
Author

elnurvl commented May 21, 2025

@shawns-valve , it seems the anniversary update reintroduced this bug. I guess the revert was unintentional, since it might be tricky to synchronize a big PR like that. If it was intentional, feel free to close the PR, though we’d be curious to know the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

at least two undefined variables cases found on the code

2 participants