Open
Conversation
lakulish
reviewed
Aug 12, 2024
Collaborator
lakulish
left a comment
lakulish
left a comment
There was a problem hiding this comment.
The change to CMAKE_CXX_FLAGS needs to occur for Linux only. Windows builds will fail otherwise.
core/build/dependencies.json
Outdated
| "-DFLATBUFFERS_BUILD_TESTS=FALSE" | ||
| "-DFLATBUFFERS_BUILD_TESTS=FALSE", | ||
| "-DCMAKE_CXX_STANDARD=17", | ||
| "-DCMAKE_CXX_FLAGS=-Wno-stringop-overflow" |
Collaborator
There was a problem hiding this comment.
This won't work on Windows, since Visual C++ doesn't recognize this flag. Instead, you'll have to specify platform-specific flags. The flatbuffers section of dependencies.json does something like that for osx. You'll have to create another such section with "platforms": ["linux-x86", "linux-x64"].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed build issues after gcc 14.1 changes and also forced C++ 17 as required by flatbuffers