fix: use clearanceCheckMask when checking for hand overlap#533
Open
meznaric wants to merge 1 commit intoValveSoftware:betafrom
Open
fix: use clearanceCheckMask when checking for hand overlap#533meznaric wants to merge 1 commit intoValveSoftware:betafrom
meznaric wants to merge 1 commit intoValveSoftware:betafrom
Conversation
Collaborator
|
How strange we missed that! Thanks for the pull. I'll integrate into the coming release. |
|
my god! after spending the whole day wondering what the problem was, i debugged and figured out this was it. i was excited about opening a pull request only to see it's already done. please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HandPhysics stops working after you release an item.
Note: I had my own colliders around the hand which were overlapping with HandPhysics, and therefore after first pickup, you cannot interact physically with an item anymore. There is clearanceCheckMask that I believe serves the purpose of telling which items this check should ignore.
The
clearanceCheckMaskis defined and can be configured, but is simply not being used when hand releases an object.This PR uses it in what I believe was intended place.
I can confirm it's working as it solved my bug.