Skip to content

Make stop() async #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arvindrk merged 1 commit into from
Sep 24, 2025
Merged

Make stop() async #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions vapi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,11 +216,13 @@ export default class Vapi extends VapiEventEmitter {
this.dailyCallObject = createSafeDailyFactoryOptions(dailyCallObject);
}

private cleanup() {
private async cleanup() {
this.started = false;
this.hasEmittedCallEndedStatus = false;
this.call?.destroy();
this.call = null;
if (this.call) {
await this.call.destroy();
this.call = null;
}
this.speakingTimeout = null;
}

Expand Down Expand Up @@ -325,7 +327,7 @@ export default class Vapi extends VapiEventEmitter {
timestamp: new Date().toISOString(),
metadata: { action: 'cleanup-existing' }
});
this.cleanup();
await this.cleanup();
}

const isVideoRecordingEnabled =
Expand Down Expand Up @@ -395,7 +397,7 @@ export default class Vapi extends VapiEventEmitter {
if (isVideoRecordingEnabled) {
this.call?.stopRecording();
}
this.cleanup();
this.cleanup().catch(console.error);
});

this.call.on('error', (error: any) => {
Expand Down Expand Up @@ -743,7 +745,7 @@ export default class Vapi extends VapiEventEmitter {
}
});

this.cleanup();
await this.cleanup();
return null;
}
}
Expand Down Expand Up @@ -800,10 +802,13 @@ export default class Vapi extends VapiEventEmitter {
}, 1000);
}

stop(): void {
async stop(): Promise<void> {
this.started = false;
this.call?.destroy();
this.call = null;
if (this.call) {
await this.call.destroy();
this.call = null;
}
this.speakingTimeout = null;
}

send(message: VapiClientToServerMessage): void {
Expand Down