feat: Remove variants from calibration responses, add dedicated variant endpoints#663
Open
bencap wants to merge 2 commits intorelease-2026.1.1from
Open
Conversation
16 tasks
bencap
changed the title
…nt endpoints
Score set API responses were slow (5+ seconds) because functional
classifications eagerly serialized thousands of variants. This moves
variant data to dedicated endpoints while keeping a lightweight
variant_count summary in the default response.
Changes:
- Remove `variants` field from functional classification view models
- Add `id` and `variant_count` fields to SavedFunctionalClassification
- Add `variant_count` column_property on the ORM model using a
correlated COUNT subquery against the association table
- Add `FunctionalClassificationVariants` response model
- Add GET /{urn}/functional-classifications/{id}/variants endpoint
- Add GET /{urn}/variants endpoint (all classifications)
- Update test constants and assertions for new response shape
Breaking change: clients relying on `variants` in calibration responses
must migrate to the new dedicated endpoints.
…das for 3.12 support
bencap
force-pushed
the
feature/bencap/659/calibration-performance-improvements
branch
from
fc3371d to
2e46417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Score set API responses were slow (5+ seconds) because functional classifications eagerly serialized thousands of variants. This moves variant data to dedicated endpoints while keeping a lightweight variant_count summary in the default response.
Changes:
variantsfield from functional classification view modelsidandvariant_countfields to SavedFunctionalClassificationvariant_countcolumn_property on the ORM model using a correlated COUNT subquery against the association tableFunctionalClassificationVariantsresponse modelBreaking change: clients relying on
variantsin calibration responses must migrate to the new dedicated endpoints.