Open
Conversation
…dd flow replace duplicated score set/experiment list UI with a reusable collection items table add inline row reordering and removal with shared handler logic and toast feedback integrate add actions into the table (footer button / empty-state link) wire table add actions to the collection data set editor dialog improve add-URN UX: Enter key triggers add pending typed URN is captured when clicking Add invalid URNs show warning toast details already-in-collection / already-queued URNs show skipped info toast simplify collection editor internals and keep save/reload behavior consistent after mutations
Collaborator
Author
|
UI Support for VariantEffect/mavedb-api#660 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way items (score sets and experiments) are managed within collections, focusing on simplifying the UI for adding items, improving error handling, and introducing a reusable table component for displaying and managing collection items. The changes remove the ability to remove items directly from the add dialog, instead delegating removal and reordering to the new
CollectionItemsTablecomponent. There are also improvements to entity caching for better performance in lists.Key changes include:
Collection Data Set Editor Refactor (
CollectionDataSetEditor.vue)New Collection Items Table Component (
CollectionItemsTable.vue)CollectionItemsTablecomponent for displaying collection items, supporting item removal, reordering (if authorized), and a clear "Add" action. This component replaces the previous list rendering and integrates with the new add-only dialog.EntityLinkimprovements for efficient rendering and provides empty state messaging and styling.Entity Link Improvements (
EntityLink.vue)Collection View Integration (
CollectionView.vue)CollectionItemsTablefor both score sets and experiments, passing the appropriate props and handling add, remove, and reorder events. The add dialog is now triggered from the table instead of being always visible.