Enhance the nix setup #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmbittner
approved these changes
Nov 26, 2024
Member
pmbittner
left a comment
pmbittner
left a comment
There was a problem hiding this comment.
Thank you for the improvements. I actually have no idea what is going on I trust you that these are improvements. 😅 What about adding documentation to the nix file to explain the design, motivation, and purpose of the specific phases and commands. At some point there is just a range of shell commands for example with almost no documentation (only in the commit message).
ibbem
force-pushed
the
enhance-nix-setup
branch
from
ba75e48 to
160fd1d
Compare
This is useful when trying to do `mvn deploy:deploy-file` or similar. Also sometimes the wrong `pom.xml` inside of the jar is chosen making the deployment invalid.
This is useful to allow reuse of DiffDetective for further builds using nix.
This is necessary for overriding dependencies of DiffDetective.
ibbem
force-pushed
the
enhance-nix-setup
branch
5 times, most recently
from
0de8c06 to
8a24971
Compare
ibbem
force-pushed
the
enhance-nix-setup
branch
2 times, most recently
from
914cfd6 to
5bd694d
Compare
ibbem
force-pushed
the
enhance-nix-setup
branch
from
5bd694d to
abe6cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly necessary to reuse the maven repository for TrueDiffDetective (0e7d810).
The other changes are fixes and possible enhancements I noticed.