Create a .editorconfig and apply it to all source files
#167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmbittner
approved these changes
Jun 13, 2025
Member
pmbittner
left a comment
pmbittner
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks for the helpful comments in the commit messages, in particular regarding git blame.
Member
|
I leave it to you when to merge this PR when you like, in case it causes annoying merge conflicts with other parallel changes. |
I checked all hand written text file extensions in use and most of them already use 4 space indent majorly. The only exceptions are *.sh, which is a wild chaos were any arbitrary decision will do, and *.nix where two space indenting is prevalent in the Nix community (i.e., Nixpkgs). See https://editorconfig.org/ for the specification and the goals of `.editorconfig` files.
If you try to blame, log or similar and hit this commit, use `-w` to skip commits like this. For example `git blame -w`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents annoying issues with inconsistent formatting (most notably it should enforce consistent whitespace usage in new files) and misconfigured editors (e.g., editors which always try to fix the formatting of the whole file, without explicit request). This also starts tackling #136 whose motivation was exactly the same, although mostly limited to Java files.