Skip to content

♻️ Add back refund to base fee vault, but changed to minBalance #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vectorized merged 1 commit into from
Aug 25, 2025
Merged

♻️ Add back refund to base fee vault, but changed to minBalance #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Gasback.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,19 +197,20 @@ contract Gasback {
$.accrued += ethFromGas - ethToGive;
}

uint256 selfBalance = address(this).balance;
// If the contract has insufficient ETH, try to pull from the base fee vault.
if (ethToGive > address(this).balance) {
if (ethToGive > selfBalance) {
address vault = $.baseFeeVault;
uint256 minBalance = $.minVaultBalance;
/// @solidity memory-safe-assembly
assembly {
if extcodesize(vault) {
// If the vault has sufficient ETH, pull from it.
if gt(balance(vault), add(sub(ethToGive, selfbalance()), minBalance)) {
if gt(balance(vault), add(sub(ethToGive, selfBalance), minBalance)) {
mstore(0x00, 0x3ccfd60b) // `withdraw()`.
pop(call(gas(), vault, 0, 0x1c, 0x04, 0x00, 0x00))
// We shall skip refunding back to the vault,
// to simplify ETH accrual logic.
// Return ETH to vault to ensure that it has `minBalance`.
pop(call(gas(), vault, minBalance, 0x00, 0x00, 0x00, 0x00))
}
}
}
Expand Down