Skip to content

Support for Custom Item Parameters #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
adamribaudo-velir wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Support for Custom Item Parameters #331

adamribaudo-velir wants to merge 3 commits into from

Conversation

@adamribaudo-velir
Copy link
Contributor

@adamribaudo-velir adamribaudo-velir commented Jul 3, 2024

Description & motivation

This PR provides support for custom item parameters using a project variable of custom_item_parameters Ex:

vars:
  ga4:
    custom_item_parameters:
      - name: "item_variant_color"
        value_type: "string_value"
        rename_to: "color"

custom item parameters are exposed in the stg_ga4__event_items model, only.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have run dbt test and python -m pytest . to validate existing tests

@adamribaudo-velir adamribaudo-velir requested a review from dgitis July 3, 2024 12:14
@adamribaudo-velir adamribaudo-velir mentioned this pull request Jul 3, 2024
Open
dgitis
dgitis approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@dgitis dgitis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a test property that uses custom item properties, but the code looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgitis dgitis dgitis approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamribaudo-velir @dgitis