Open
Conversation
The SimpleDraweeSpanTextView found in the c4 class used in UsernameView ignores any font set in the ResourcesCompat hook, causing the user list (found on the right sidebar) to use the default font, even when all other UI elements properly make use of the fonts set by the theme. Test: manual - 1. Deploy Themer to a device with the font hook enabled 2. Load Themer without any theme 3. Open the right side bar, ensure the default font is set 4. Load any theme that changes the whitney_medium font (or alternatively, all fonts/"*") and restart 5. Open the right side bar in any guild/DM and see the theme font is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Themer to load custom fonts, the names found in the user list (right side bar) for some reason remain unthemed; the default font will load over the font defined by the theme itself.
This PR should address that in a (hopefully) clean way. From my test, there doesn't seem to be any regression visible from this change, but I've only done the rudimentary just to make sure nothing catches on fire.