[PLAT-7622] Fix upgrade issue #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the same changes we discovered with the teamcenter client using the OpenAPI generator and how it by default doesn't allow the server to update the schema. This also adds the usage of the discriminators and fixes the issues around matching the oneof using the shape.
See the PRs 89 and 90 for some more information about this issue.
Customized oneof_model.mustache is taken from here: oneof_model.mustache
Test Plan
Best to test using in a client like PlmIntegrationService
Release Notes
None
Possible Regressions
Could make the client match on multiple oneof objects if the descriminator isn't defined on the object.