Fix short overflow in legacy velocity handling #1171
Merged
+34
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clamp the velocity conversion result to the valid short range to prevent overflow and invalid velocity values
Contributor
Author
|
I've noticed on a 1.21.11 server if you had a KB 10 enchantment and hit a pre 1.21.9 client they would go flying the opposite way that you hit them from Unfortunately you can't get the pre-1.21.9 client to get the full velocity, but clamping it will leave the closest result Better than the velocity value overflowing and causing weird issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clamp the velocity conversion result to the valid short range to prevent overflow and invalid velocity values