Skip to content

Conversation

@lonelyJM
Copy link

This PR fixes 1.7 holograms from becoming invisible after refreshing their content.

Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The armor stand name can also be invisible, how do I reproduce this issue?

@lonelyJM
Copy link
Author

I was changing the display mode on the Ranked leaderboard in Practice, and after the hologram refreshed, it disappeared.
sometimes it also disappears on its own after a while.

@FlorianMichael
Copy link
Member

does that bug also happen with 1.8 players?

@lonelyJM
Copy link
Author

1.8 players will not trigger this bug

@EthanKeating
Copy link
Contributor

Never had this issue, are you using an API or are you managing holograms yourself?

@FlorianMichael
Copy link
Member

IDK, unless you provide more details on how your setup looks like, I am against this change. The information should be inherited as the server could also use this intentionally to hide the hologram. There could be something wrong in the current emulation code, but just removing the field usage definitely doesn't look like a correct fix (even though it solves your specific situation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants