Skip to content

Proof of concept: Two types of decoders #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hello-im-szymon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proof of concept: Two types of decoders #2

hello-im-szymon wants to merge 1 commit into from

Conversation

@hello-im-szymon
Copy link
Collaborator

@hello-im-szymon hello-im-szymon commented Aug 28, 2020

This allows for a bit less strict decoders. For example:

private struct ImageDecoder: ConcreteTypeDecoder {

    enum DecodingError: Error {
        case invalidData
    }

    func decode(_ data: Data) throws -> UIImage {
        guard let image = UIImage(data: data) else {
            throw DecodingError.invalidData
        }
        return image
    }

}

The API is not changed for existing clients.

hello-im-szymon
hello-im-szymon commented Aug 28, 2020
View reviewed changes
Sources/URLSessionDecodable/DataDecoder.swift
// For legacy reasons
public typealias DataDecoder = AnyTypeDecoder

public protocol ConcreteTypeDecoder {
Copy link
Collaborator Author

@hello-im-szymon hello-im-szymon Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hello-im-szymon