Merged
Conversation
…ng mistakes, a lot of factual mistakes, fixed a lot of completely broken code, covered all endpoints, updated models in most cases
…d some mistakes, added new response models
…ot of mistakes in the naming and endpoint URLs, added new response models
…added new response models
…pto Loan. Completely added all Earn endpoints, and models for Earn endpoints
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the bybit.net.api library from version 1.0.9 to 1.2.0, bringing significant feature additions and improvements. The update includes enhanced API coverage across multiple categories, new service implementations, bug fixes, and improved gitignore configuration for better repository management.
- Enhanced existing API services with new endpoints and corrected method names
- Added three new major service categories: Earn, P2P, and New Crypto Loan services
- Expanded coverage of Market, Trade, Position, Account, User, Affiliate, and Spot Margin Trade categories
Reviewed Changes
Copilot reviewed 125 out of 472 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| Src/Common/bybit.net.api.csproj | Version bump from 1.0.9 to 1.2.0 with assembly version alignment |
| Src/Common/ApiServiceImp/*.cs | Multiple service implementations with new endpoints, bug fixes, and method name corrections |
| Src/Common/Models//.cs | New model classes for P2P, Earn, New Crypto Loan, and other expanded API categories |
| Examples/bybit.api.console/Program.cs | Updated example code to demonstrate proper usage patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
|
ignore Copilot, all the changes proposed were already fixed by me, the code is ready to be merged |
VictorFrWu
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please view commits for all the changes.
Most notable changes:
Version bumped to v1.2.0, ready for release