Conversation
tonyghiani
reviewed
Jul 29, 2019
tonyghiani
left a comment
tonyghiani
left a comment
There was a problem hiding this comment.
The server is actually pretty good and well done, you could split your controllers in more modules to keep your files short, like the authentication functions for example.
There is only one thing that needs to be fixed and is wrong: never, never, never push on your repository you env variables which contains your secrets. That is a file that should be added to the .gitignore and never shared on a public repository, since it could contains informations related to private accounts. Even id it ddoesn't contains real informations, be sure to remove it from the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.