Skip to content

Conversation

@No0ne558
Copy link
Contributor

Summary

  • Prevent Job Security buttons from double-triggering; activation/deactivation no longer immediately reverts.
  • Hardware view now shows only the list by default; configuration appears only after an explicit “change view” signal.
  • Changelog updated to document both fixes.

Technical Details

  • JobSecurityZone::Touch now calls FormZone::Touch only once; confirmation dialog flow unchanged.
  • HardwareZone render split: list mode uses LayoutZone + list_report; form mode uses FormZone render with headings per section.
  • Hardware list selection no longer auto-loads form; “change view” loads the selected record into the form before rendering.
  • Added <cstring> include and fixed header guard in hardware_zone.hh.

Testing

  • Build: make -j9 (pass).
  • Manual TODO: verify Hardware stays in list until “change view”, and Job Security toggles persist.

Files

  • user_edit_zone.cc
  • hardware_zone.cc
  • hardware_zone.hh
  • changelog.md

Commit

  • Fix job security touch flow and hardware view toggle (5939fc0)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix two UI interaction issues: preventing double-touch in Job Security zone buttons and separating Hardware view's list and form modes. The changes modify touch handling to avoid immediately reverting user actions and ensure Hardware view remains in list mode until explicitly switched.

Key changes:

  • Remove premature FormZone::Touch call in JobSecurityZone to prevent double-triggering
  • Override HardwareZone::Render to conditionally render list or form views
  • Override HardwareZone::Touch to defer record loading until "change view" signal
  • Update HardwareZone::Signal to load records when entering form mode from list

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
zone/user_edit_zone.cc Removes early FormZone::Touch call in JobSecurityZone::Touch to prevent double-touch behavior
zone/hardware_zone.hh Fixes header guard naming consistency and declares new Touch override method
zone/hardware_zone.cc Implements split rendering (list vs form), custom Touch handling, and deferred record loading on view toggle; adds cstring include for strcmp
main/data/archive.cc Fixes lambda capture to avoid capturing uninitialized variable (documented under "Static Analysis Cleanups")
docs/changelog.md Documents the Job Security and Hardware view fixes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@No0ne558 No0ne558 merged commit afe7390 into ViewTouch:dev Dec 24, 2025
12 checks passed
@No0ne558 No0ne558 deleted the dev branch December 24, 2025 01:36
@No0ne558 No0ne558 restored the dev branch December 24, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant