Skip to content

Conversation

@RHammond2
Copy link
Collaborator

@RHammond2 RHammond2 commented Oct 8, 2025

This PR replaces the use of the deprecatednp.trapz with its renamed np.trapezoid function, and removes support for Python 3.9. The former removes a DeprecationWarning that appears whenever the code is run, and the latter addresses 1) Python 3.9's upcoming EOL, and 2) modern benedict's lack of support in later versions . All tests pass, and the changelog has been updated to indicate the new version.

@RHammond2 RHammond2 requested a review from nRiccobo October 8, 2025 15:59
@RHammond2 RHammond2 added the bug label Oct 8, 2025
@RHammond2 RHammond2 changed the title Patch: v1.2.2, Replace deprecated NumPy trapz method Patch: v1.2.2, Replace deprecated NumPy trapz method and sunset Python 3.9 Oct 8, 2025
Copy link
Collaborator

@nRiccobo nRiccobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Thank you for updating the README, changelog, and advancing the version number. After this can you merge these into dev to sync them up?

@RHammond2 RHammond2 merged commit ba4ed6e into WISDEM:main Oct 9, 2025
33 checks passed
@RHammond2 RHammond2 deleted the patch/trapz-deprecation branch October 9, 2025 16:36
github-actions bot pushed a commit that referenced this pull request Oct 9, 2025
…hon 3.9 (#198)

* replace deprecated functionality

* update changelog and bump version

* deprecate 3.9 compatibility for EOL and benedict's lack of support for 3.9
github-actions bot pushed a commit to nRiccobo/ORBIT that referenced this pull request Oct 9, 2025
…hon 3.9 (WISDEM#198)

* replace deprecated functionality

* update changelog and bump version

* deprecate 3.9 compatibility for EOL and benedict's lack of support for 3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants