update narf (histogram and quantile histogram helpers)#654
Open
bendavid wants to merge 1 commit intoWMass:mainfrom
Open
update narf (histogram and quantile histogram helpers)#654bendavid wants to merge 1 commit intoWMass:mainfrom
bendavid wants to merge 1 commit intoWMass:mainfrom
Conversation
Collaborator
Author
|
No changes in the CI as expected, so this can be merged. |
Collaborator
|
A real test for the new functionality would be to make the replacement already in this PR, can this be done? @lucalavezzo can you look into this? |
Collaborator
Author
|
I discovered afterwards that this would actually require the new singularity (something with cppyy/cling which doesn't work in the older root version) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update narf with new histogram helpers (both for the generic case and for conditional quantile binning, see bendavid/narf#39)
Eventually WRemnants can/should transition to using the generic HistHelper in place of HistHelper1D, 2D...