Conversation
Collaborator
Author
|
(CI will fail until the new container version propagates to cvmfs) |
…els (with fallback for existing environments)
bendavid
force-pushed
the
singularity_v45
branch
from
525f670 to
6af724c
Compare
bendavid
force-pushed
the
singularity_v45
branch
6 times, most recently
from
ca3331a to
29eeddf
Compare
bendavid
force-pushed
the
singularity_v45
branch
from
29eeddf to
427a8df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major upgrade of singularity container to v45 (see https://gitlab.cern.ch/bendavid/cmswmassdocker/-/commits/v45?ref_type=tags)
Some small corresponding technical updates which are needed (migrate python tensorflow lite usage to new litert package)
Also fix a few array out of bounds accesses (off by one errors) which caused problems after the ROOT/cling/etc update (but were already bugs previously in principle)
Note that critically now we are back to a situation again where we cannot/should not import tensorflow before the event loop (but we no longer need to)
I will see if a reasonable solution can be found to this stripping off symbols, but it might also be ok like this. (if it happens by mistake narf will detect it and give a descriptive error rather than failing mysteriously/unpredictably)