add additional Typoscript configuration for dependency scss.#15
Open
SCPhilippHolzmann wants to merge 4 commits intoWapplerSystems:legacyfrom
Open
add additional Typoscript configuration for dependency scss.#15SCPhilippHolzmann wants to merge 4 commits intoWapplerSystems:legacyfrom
SCPhilippHolzmann wants to merge 4 commits intoWapplerSystems:legacyfrom
Conversation
Collaborator
|
I personally would not make the SCSS files of my template extension dependent on another extension. That would be too uncertain for me. I would always prefer an independence. I would always copy the SCSS files of other extensions into my extension, because I usually modify them then. |
added 3 commits
May 29, 2020 12:08
# Conflicts: # Classes/Hooks/RenderPreProcessorHook.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add a typoscript variable to define dependencies of a Scss file. I made this to allow other extensions to override scss variables of the dependencies.
Here is a example how the typoscript configuration look like
page.includeCSS{ customer = EXT:t3s_customer/Resources/Private/sources/Scss/customer.scss customer.dependencies { 5 = EXT:my_extension/Resources/Private/sources/scss/bootstrap/functions 10 = EXT:my_extension/Resources/Private/sources/scss/customer-variables } }