Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Nov 22, 2025

Description

This PR enables OME Parquet column and index specification. I also added a warning when a default is automatically selected. The change also needed ipykernel to make sure the notebook could run in VS code effectively from the uv environment.

Closes #8

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d33bs d33bs marked this pull request as ready for review November 22, 2025 21:12
@d33bs d33bs requested a review from jenna-tomkinson December 1, 2025 17:15
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am a bit lost how the ome.parquet files got created before the example but maybe a README could make that easier to understand.

@d33bs
Copy link
Member Author

d33bs commented Dec 1, 2025

Thanks @jenna-tomkinson !

@d33bs d33bs merged commit 0496fa1 into WayScience:main Dec 1, 2025
9 checks passed
@d33bs d33bs deleted the parquet-multi-image branch December 1, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle multi-image columns and multiple columns of images in OME Parquet files

2 participants