Fix NA check in pi.h indexing logic inside Gibbs.subclone.density.est#36
Open
sanroman-24 wants to merge 2 commits intoWedge-lab:masterfrom
Open
Fix NA check in pi.h indexing logic inside Gibbs.subclone.density.est#36sanroman-24 wants to merge 2 commits intoWedge-lab:masterfrom
sanroman-24 wants to merge 2 commits intoWedge-lab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a logical condition used to check whether indices contains only NA values.
Previously, the code used
if (is.na(indices)), which only works correctly when indices is a scalar. When indices is a vector,is.na(indices)returns a logical vector, causing a warning or an error (the condition has length > 1).The updated condition if (all(is.na(indices))) correctly detects when all elements of indices are NA, preventing unexpected behavior when indices is a vector.
Changes
if (is.na(indices))withif (all(is.na(indices)))to handle vector inputs safely.