Update to pulse multiplier for accurate power data#2
Open
miragebird wants to merge 1 commit intoWeekendWarrior1:emerald_blefrom
Open
Update to pulse multiplier for accurate power data#2miragebird wants to merge 1 commit intoWeekendWarrior1:emerald_blefrom
miragebird wants to merge 1 commit intoWeekendWarrior1:emerald_blefrom
Conversation
Updated average power formula and included a conversion variable for hrs to s.
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated average power formula and included a conversion variable for hrs to s.
What does this implement/fix?
This fix uses a new pulse multiplier formula to estimate power output, this results in a x4 increase in power output, but will be colser to the actual power output with an accuracy +/- 120 W (assuming a 1000 pulses/kWh). Ideally if the timestamps were known for each pulse (or the delta) we could increase this accuracy further. Pretty basic code change so hopefully I didn't break anything. Tested locally, but please verify on your own device using:
Types of changes
Related issue or feature (if applicable): fixes WeekendWarrior1/emerald_electricity_advisor/issues/4
Test Environment
Example entry for
config.yaml:Checklist:
tests/folder).