Yaohan_Ashley_Personal_Website#16
Open
YaohanXu wants to merge 96 commits intoWeitzman-MUSA-JavaScript:mainfrom
Open
Yaohan_Ashley_Personal_Website#16YaohanXu wants to merge 96 commits intoWeitzman-MUSA-JavaScript:mainfrom
YaohanXu wants to merge 96 commits intoWeitzman-MUSA-JavaScript:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tried to combine the need of this final project to engage the general pubic with our own needs to display the selected projects. That’s how we came up with this idea of a personal website which can also work as a community for people to share their comments on different projects.
The website has three main pages: projects page, comments page and about me page. Additionally, each project also has its own project page which can be generated automatically.
The link of the recorded video for final presentation is here: https://upenn.box.com/s/nzvk3yu68xgbzujcheyy298a7hp5j5vw (If you meet with any problem to have access to this, you can just email me or slack me about this).
Finally, we have a functional problem related to the transition of loading page.
I think the problem is about this piece of JS code:
window.addEventListener('load', () => {
document.body.classList.add('loaded'); // Add the loaded class to the body
});
And this piece of CSS code:
body {
height: auto;
width: 100%;
max-width: 1000px;
margin: 0 auto;
padding: 0;
opacity: 0;
transition: opacity 0.75s ease-in-out; /* for fade-in effect */
}
body.loaded {
opacity: 1; /* for fade-in effect */
}
You may meet with a problem when switching back and forth between different pages frequently (sometimes it works well!). However, if I delete the transition function (or just change the initial opacity of the body element to 1), the website will work correctly.
Thank you so much if you could help with this page-loading transition problem!