feat(core): implement standard logging class#11
Open
thereis wants to merge 3 commits intoWhiskeySockets:masterfrom
Open
feat(core): implement standard logging class#11thereis wants to merge 3 commits intoWhiskeySockets:masterfrom
thereis wants to merge 3 commits intoWhiskeySockets:masterfrom
Conversation
|
That is great |
Member
no need for the env variable. please move it to work with pino and then we can embed the socket's logger into there. Then if the user sets his socket logger to silent, he won't hear anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a standard library for logging, eliminating the need for
console.log.The reason for this is that when using an observability tool that integrates with pino or any other JSON logging, we can't capture or silence the logs from this library, resulting in poor DX or poor readability.
To silence the libsignal logs, set an environment variable: