Skip to content

Conversation

@JasonWildMe
Copy link
Collaborator

Fix null names issue on popup resulting no-match click on results page.

PR fixes #1260

This is a temporary fix lasting only until 10.10 replaces the page entirely.

Fix null names issue on no match from issue 1260
@JasonWildMe JasonWildMe requested a review from vkirkl December 19, 2025 16:52
@JasonWildMe JasonWildMe self-assigned this Dec 19, 2025
@JasonWildMe JasonWildMe marked this pull request as ready for review December 28, 2025 05:32
@JasonWildMe JasonWildMe requested a review from naknomum January 5, 2026 19:10
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.55%. Comparing base (6b6449b) to head (b9665de).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1354   +/-   ##
=========================================
  Coverage     11.55%   11.55%           
  Complexity     1307     1307           
=========================================
  Files           710      710           
  Lines         72933    72933           
  Branches      14036    14045    +9     
=========================================
  Hits           8425     8425           
  Misses        63592    63592           
  Partials        916      916           
Flag Coverage Δ
backend 11.55% <ø> (ø)
frontend 11.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@holmbergius holmbergius merged commit 82895b0 into main Jan 5, 2026
1 of 2 checks passed
@holmbergius holmbergius deleted the fix-issue-1260 branch January 5, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirm No Match uses "null" instead of ID in confirmation message

5 participants