use models for rendering instead #370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celestialfault
force-pushed
the
fix/pretend-to-use-models
branch
from
1eb90ba to
3246b26
Compare
apparently trims still z-fight without the delta, even though that wasn't an issue last time i made these same changes...
celestialfault
force-pushed
the
fix/pretend-to-use-models
branch
from
3246b26 to
77245e6
Compare
this also changes the dz on armor models to 3, as i feel like doing so makes these models match the vanilla texture better
celestialfault
force-pushed
the
fix/pretend-to-use-models
branch
from
9143e0d to
a688b05
Compare
[ci skip]
move the portion of the texture used for the 'up' face (which is actually the underside of the breast?) up by one pixel to match how this used to be rendered prior to 1.21.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?
What changes does this PR make?
Changes our rendering to (mis)use Minecraft's
Modelinstead of the current custom renderer, which shaders seem to handle better.Fixes #369
Anything else we should know?
Opening as a draft as it'd be nice to take the opportunity to also fix armor UVs (see the associatedFIXMEcomment inGenderArmorLayer.java), but I don't really have the motivation to look into these UVs right now