This repository was archived by the owner on Jan 21, 2024. It is now read-only.
Optimize Network Queue (SportPaper-0108) #127
Open
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure that it's better? Incrementing was heavy, I would benchmark it before adding. |
Author
Im not totally sure, but Paper added it so it seems that they atleast thought it was a good idea. Im don't exactly know how I would Benchmark this but I would do one if I could. It just looked good on paper so I thought I would add it. |
|
Benchmarking would need to test adding and polling from the queue at once. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[+] Add CachedSizeConcurrentLinkedQueue from Paper
[~] Change Network Queue in MinecraftServer from ConcurrentLinkedQueue to CachedSizeConcurrentLinkedQueue.
In the Future maybe other Queues can be changed to this for a slight performance increase.