Conversation
…atically calls `YieldAsynchronousTask` internally
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new taskWaitYield function that serves as a replacement for TaskWait, automatically calling Internal\YieldAsynchronousTask` internally to prevent blocking other asynchronous tasks. The implementation uses a polling loop with incremental delays and supports configurable time constraints.
Changes:
- Added new
taskWaitYieldfunction in Utils.wl with Listable attribute and TimeConstraint option support - Replaced
TaskWaitcalls withtaskWaitYieldin VectorDatabases.wl, RelatedWolframAlphaResults.wl, and LLMUtilities.wl - Exported
taskWaitYieldvia CommonSymbols.wl for use across the codebase
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Chatbook/Utils.wl | Implements the new taskWaitYield function with yield-while-waiting logic and adds configuration constant $initialTaskWaitDelay |
| Source/Chatbook/PromptGenerators/VectorDatabases.wl | Updates local taskWait wrapper to delegate to taskWaitYield instead of TaskWait |
| Source/Chatbook/PromptGenerators/RelatedWolframAlphaResults.wl | Replaces direct TaskWait call with taskWaitYield for API content requests |
| Source/Chatbook/LLMUtilities.wl | Replaces TaskWait with taskWaitYield in LLM synthesis workflow |
| Source/Chatbook/CommonSymbols.wl | Exports taskWaitYield symbol for use across Chatbook packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.