Conversation
+ Added interop for new filterNode option for prettyDom + Fixed misc. tests — JS CHANGELOGS — - https://github.com/testing-library/dom-testing-library/releases/tag/v8.0.0 - https://github.com/testing-library/react-testing-library/releases/tag/v12.0.0
| "@babel/cli": "^7.12.13", | ||
| "@babel/core": "^7.12.13", | ||
| "@babel/plugin-transform-runtime": "^7.12.15", | ||
| "@babel/preset-env": "^7.12.13", | ||
| "@babel/preset-typescript": "^7.12.13", | ||
| "babel-plugin-transform-inline-environment-variables": "^0.4.3", | ||
| "@rollup/plugin-babel": "^5.2.3", | ||
| "@rollup/plugin-commonjs": "^17.1.0", | ||
| "@rollup/plugin-json": "^4.1.0", | ||
| "@rollup/plugin-node-resolve": "^11.1.1", | ||
| "rollup": "^2.38.5", | ||
| "rollup-plugin-filesize": "^9.1.0", | ||
| "rollup-plugin-node-builtins": "^2.1.2", | ||
| "rollup-plugin-node-globals": "^1.4.0" | ||
| "vite": "^5.4.9" |
There was a problem hiding this comment.
Wow that's cool that vite replaced all those!
| await rtl.waitFor(() async { | ||
| numRuns++; | ||
| expect(numRuns, 5); | ||
| expect(numRuns, 3); |
There was a problem hiding this comment.
Is this just to make the test faster or did waitFor change somehow?
There was a problem hiding this comment.
Good question, we should look into this; will probably just have to try changing it locally and see what happens
There was a problem hiding this comment.
I reverted this back to 5 and it passes locally and CI so 🤷♀️ might have been some merge conflict thing or something
| external bool? Function(Node?)? get filterNode; | ||
| external set filterNode(bool? Function(Node?)? value); |
There was a problem hiding this comment.
Is there a reason the arg and return value aren't typed as non-nullable like in the TS type?
| external bool? Function(Node?)? get filterNode; | |
| external set filterNode(bool? Function(Node?)? value); | |
| external bool Function(Node)? get filterNode; | |
| external set filterNode(bool Function(Node)? value); |
There was a problem hiding this comment.
Good catch; not that I'm aware of, and we can probably update this
|
@sydneyjodon-wk Thanks for the comments! You cool if we address those in the follow-up to add dual-17/18 support? |
|
@greglittlefield-wf yep that works for me! |
|
i love this |
|
@kealjones-wk you mean the parts that you did? 😁 |
5 participants
No description provided.