Conversation
sydneyjodon-wk
previously approved these changes
May 7, 2025
sydneyjodon-wk
previously approved these changes
May 7, 2025
greglittlefield-wf
requested changes
May 7, 2025
Contributor
greglittlefield-wf
left a comment
greglittlefield-wf
left a comment
There was a problem hiding this comment.
Just one comment on the formatting, otherwise LGTM!
greglittlefield-wf
requested changes
May 7, 2025
Contributor
greglittlefield-wf
left a comment
greglittlefield-wf
left a comment
There was a problem hiding this comment.
Changes look good to me, but @sydneyjodon-wk would you mind squashing your commits so that the formatting diffs back and forth don't end up in the Git history?
.github/workflows/ci.yaml
Outdated
|
|
||
| - name: Check formatting | ||
| run: dart format . -l 120 --set-exit-if-changed | ||
| if: ${{ always() && steps.install.outcome == 'success' }} |
Contributor
Author
There was a problem hiding this comment.
This line can be removed now, there's no install step, and no need to always execute it
sydneyjodon-wk
force-pushed
the
use_gha-dart-oss
branch
from
48e0e26 to
fa520e2
Compare
btr-rmconsole-4
bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Contributor
|
@Workiva/release-management-p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
From this convo in support - we should be using the standard OSS CI checks
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: