quotechar-fix

[alhelguera]

No description provided.

[david-i-berry]

This does not fix the underlying issue. The issue comes from here:

csv2bufr/csv2bufr/__init__.py

Lines 845 to 860 in 7ac4612

	# quoting
	if 'QUOTING' in mappings:
	_quoting = mappings['QUOTING']
	elif 'quoting' in mappings:
	_quoting = mappings['quoting']
	else:
	_quoting = QUOTING
	_quoting = getattr(csv, _quoting)
	if 'QUOTECHAR' in mappings:
	_quotechar = mappings['QUOTECHAR']
	if 'quotechar' in mappings:
	_quotechar = mappings['quotechar']
	else:
	_quotechar = QUOTECHAR

and

csv2bufr/csv2bufr/__init__.py

Lines 868 to 869 in 7ac4612

	reader = csv.reader(fh, delimiter=_delimiter, quoting=_quoting,
	quotechar=_quotechar)

There has been a change in behaviour of csv.reader and it has become stricter in validating the quotechar argument leading to the error. We need to fix the arguments passed to csv.reader and to omit the quotechar when quoting in none.

[alhelguera]

Hi @david-i-berry check last commit to see the new proposed fix.

[david-i-berry]

Something like

kwargs = {
    "quoting":  _quoting,
    "delimiter": _delimiter
}

if _quoting != csv.QUOTE_NONE:
    if len(_quotechar) == 1:
        kwargs["quotechar"] = _quotechar
    else:
        # warning or error (to be added)
        pass

reader = csv.reader(fh, **kwargs)