Make app callable from commandl ine by just doing scdefg after pip installing.#3
Make app callable from commandl ine by just doing scdefg after pip installing.#3
scdefg after pip installing.#3Conversation
…stalling. Should be good for pypi now
There was a problem hiding this comment.
adding entry_points to setup.py works beautifully when running the app from a terminal and both PR #3 and #4 look ok, but now I can't figure out how to run the app from gunicorn, a fundamental step in our deployment. I tried to add a wsgi file (as suggested here https://www.digitalocean.com/community/tutorials/how-to-serve-flask-applications-with-gunicorn-and-nginx-on-ubuntu-18-04) with the code that is now commented out at the bottom of app.py and this works fine. I can add this file to the PR and change the systemd configuration to point to the new file, but I wanted to hear if you had an alternative way to run the app with gunicorn before adding my changes. Also, should I commit them to #3 or to #4?
|
I don't really know of a better way of deploying with Gunicorn. Let's make the changes to #4, it is cool to have external contributors. However, let's keep the command to be just |
|
Ok cool, I'll add the wsgi file to #4 |
Should be good for pypi now
@valearna if these changes are good please merge to main and I'll put it on pypi