Fix slice index bug in NR ROI filter that excluded last event's final vertex#373
Merged
cfuselli merged 3 commits intonr_micro_clustering_carlofrom Jan 29, 2026
Merged
Conversation
Co-authored-by: cfuselli <62354392+cfuselli@users.noreply.github.com>
Co-authored-by: cfuselli <62354392+cfuselli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on NR filter and logic updates
Fix slice index bug in NR ROI filter that excluded last event's final vertex
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
Fixes a slice indexing bug in
filter_events()where the last vertex of the last event wasn't marked for removal when the NR ROI check failed.Can you briefly describe how it works?
The inner loop variable
vertex_ihas different meanings depending on loop exit:vertex_ipoints to next event's first vertexvertex_ipoints to current event's last vertexThe original slice
vertex_to_keep[start_index:vertex_i]worked for breaks but excluded the final vertex when the loop completed.Fix: Track loop exit with boolean flag
loop_brokeand adjust end index accordingly:Can you give a minimal working example (or illustrate with a figure)?
Before fix - last event with 3 vertices fails ROI check:
After fix:
# Returns: [1. 0. 0. 0.] ✓ All event 1 vertices removedPlease include the following if applicable:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.