Skip to content

Add triggers for overlooked comms#26

Open
georgestephanis wants to merge 1 commit intoXavious:masterfrom
georgestephanis:patch-4
Open

Add triggers for overlooked comms#26
georgestephanis wants to merge 1 commit intoXavious:masterfrom
georgestephanis:patch-4

Conversation

@georgestephanis
Copy link
Contributor

I still need to add the conditionals for them and everything, but this should be the right triggers I believe.

This isn't ready to merge yet until the conditionals for the new triggers are set up yet.

I still need to add the conditionals for them and everything, but this should be the right triggers I believe.
@georgestephanis
Copy link
Contributor Author

Not sure if we should also do 'yells' --

A tough-looking pirate thug yells, 'Your blood is mine!' and You yell, 'cookies for all'

@Xavious
Copy link
Owner

Xavious commented Jan 5, 2022

This is way more granular than I would ever go. However, as long as they are set up as toggleable options like the rest, then I see no reason not to provide people with more options.

I didn't actually write this script, but I did add the mindtalk/farspeak functionality to it. You just have to follow the wire for one of the already working channels to see an example of what you need to replicate for echo toggles, etc.

@georgestephanis
Copy link
Contributor Author

Some of the picking up of "whispered into comlinks" may be less useful generally, but catching hails and radio and stuff definitely feels useful, especially in era 2 when there's more likely to be ship checkpoints

@Xavious
Copy link
Owner

Xavious commented Jan 5, 2022

I can definitely see that being a worthwhile feature for people. I'm picky about my personal choices for echos. For example, I do not route my says into the mini window, because I see it as more of a "comlink" chatter box for me. The plugin is not just for me though!

If you're interested in a nice little reference for the updates I made to get mindtalk/farspeak working, have a look at this: ca5d857

Edit: If you do reference that ☝️ , you can ignore the state stuff. You really only need to worry about the plugin file. When it's finished and ready I would be the one to go in an re-run everything to get the state files back up to speed before updating the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants