Add NP3 Overlay to the HD build#3129
Draft
BlossomFrog wants to merge 1 commit intoXeeynamo:masterfrom
Draft
Conversation
Xeeynamo
reviewed
Feb 16, 2026
Owner
Xeeynamo
left a comment
Xeeynamo
left a comment
There was a problem hiding this comment.
Hey @BlossomFrog 👋 thank you for your contribution!
Adding a new overlay is quite the challenge even for a seasoned contributor. I am impressed and excited of your submission!
As you might have noticed, most of the conditional code only enabled for PSP is also found on HD. This is because it looks like the PSP build was based on the HD one, which seems to be a Japanese build prior to the US build.
There is a CI failure on make build_all, but weirdly it does not fail with VERSION=hd make build_hd. Do you mind having a look locally to verify if there's something you might've missed? JFYI, this PR is very close to be ready to be merged!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the np3 stage overlay to the hd build using the existing np3 code. This mainly consists of additions to the config files for the hd build. Some modifications were made to existing preprocessor directives to filter for VERSION_HD, but otherwise no additions to the existing code were needed to get a full match. The config files use the same structure as the us version, just with different offsets, so it shouldn't be too hard to update as the np3 code is updated.
Note: I'm not sure if this counts as adding a new overlay or not, but I figured there's no harm in making a pull request regardless.