Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns the PR build workflow with the release build process to catch publish issues earlier, and ensures third-party license generation is reliable by treating nuget-license failures as build errors.
Changes:
- Added environment variables and build preparation steps to
.github/workflows/pr-build.ymlto mirror the release workflow - Modified the publish command to use the same publish profile resolution as the release build
- Enhanced
YouTubeMusicStreamer.csprojto create the license output directory, capturenuget-licenseexit codes, emit warnings/errors based on exit status, and include generated license files in the build output
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/pr-build.yml |
Added environment variables and build preparation steps to match release workflow; updated publish command to use computed publish profile |
YouTubeMusicStreamer/YouTubeMusicStreamer.csproj |
Added directory creation for license output, exit code handling for nuget-license, and configured license files as MAUI assets with copy-to-output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
release-buildjob so PR checks are more likely to surface release-time publish issues.nuget-licensefailures are not silently ignored.Description
.github/workflows/pr-build.ymlto addOS,APP_NAME,ARCH,RELEASE_NOTES_FILE,VPK_OUTPUT_DIR,VPK_PACK_AUTHORS, andVPK_PACK_TITLEenvironment variables and to add thePrepare build env,Set dynamic VPK env vars,.NET setup, and NuGet cache steps so the PR job mirrors the release build up through publish while remaining single-arch.dotnet publishwith-p:PublishProfile=${{ env.VPK_CHANNEL }}so the same publish profile computation is used as in release.YouTubeMusicStreamer.csprojadd a<MakeDir>to ensureResources\Raw\ThirdPartyLicensesexists before generation and rundotnet tool restorethendotnet tool run nuget-licensewhile capturing its exit code intoNuGetLicenseExitCode.WarningwhenNuGetLicenseExitCode == 3and anErrorfor any exit code other than0or3, and addMauiAssetitems forResources\Raw\third-party-licenses.jsonandResources\Raw\ThirdPartyLicenses\**withCopyToOutputDirectory=Alwaysso generated license files are packaged.Testing
mainand verify the updated steps and publish behavior.Codex Task