fix: generate license assets outside maui raw#11
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a MAUI publish conflict (NETSDK1152) caused by duplicate asset inclusions when nuget-license generated files were caught by both the MauiAsset wildcard and explicit includes. The solution moves license generation to an intermediate build directory while preserving the final published file layout.
Changes:
- Moved license file generation from
Resources\Rawto$(BaseIntermediateOutputPath)to avoid overlap with the catch-allMauiAssetwildcard - Removed the workaround of explicitly removing and re-adding license assets, replacing it with direct includes from the intermediate directory with
LogicalNamemappings - Simplified the
MauiAssetwildcard include by removing the need for exclusions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MauiAsset Include="Resources\Raw\**"so they were double-published.Resources\Rawas a workaround and instead produce the generated files in an intermediate build directory while preserving their final logical locations.Description
MauiAsset Include="Resources\Raw\**"(noExclude) and moved license generation out of the source tree to avoid duplication at publish time.GenerateThirdPartyLicensestarget to create$(BaseIntermediateOutputPath)ThirdPartyLicensesand runnuget-licensewith output files placed under$(BaseIntermediateOutputPath).MauiAssetincludes that point at$(BaseIntermediateOutputPath)third-party-licenses.jsonand$(BaseIntermediateOutputPath)ThirdPartyLicenses\**withLogicalNamemappings so the published layout remainsthird-party-licenses.jsonandThirdPartyLicenses\....CopyToOutputDirectoryset toAlwaysfor the included assets so runtime access and publish output are unchanged.Testing
Codex Task