You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I also updated Subdomain with new member functions and the example file to the new simulationSetup.hpp standards.
Unfortunately, the example is very inefficient at the moment due to serially looping over all particles twice in 02_LennardJones_IdealGas_LocalCap.cpp:198-222. We might opt for rethinking force calculation as well in the future.
I don't understand the error for the nvcc debug build. I define the subdomain exactly the way it is done in Subdomain.test.cpp:66, which hasn't made any problems yet.
Alright, apparently the error was that I initialized the Point3D argument of the Subdomain constructor with the object member config.neighborCutoff rather than the static constexpr class member Config::neigborCutoff.
I suppose that this is some strange interaction in between the {} constructor for the Point3D object and the static constexpr nature of the member.
Is that correct or what would be the correct explanation?
Where is this {} constructor for Point3D defined?
Why did this issue only appear for nvcc and only when I initialized the Point3D manually? After all, the Subdomain constructor does exactly the same internally, doesn't it?
Depending on what the answers are to these questions, maybe it would be better to only use the static constexpr members of the Config class rather than the config object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #72.
Relates to #76.
I also updated Subdomain with new member functions and the example file to the new simulationSetup.hpp standards.
Unfortunately, the example is very inefficient at the moment due to serially looping over all particles twice in 02_LennardJones_IdealGas_LocalCap.cpp:198-222. We might opt for rethinking force calculation as well in the future.