Skip to content

hotfixed device error in interpolation #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
J-Hizzle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

hotfixed device error in interpolation #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64cdd21
hotfixed device error in interpolation
J-Hizzle Mar 3, 2026
c063144
Merge branch 'XzzX:main' into main
J-Hizzle Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions mrmd/util/interpolation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,18 @@ namespace util
{
data::MultiHistogram interpolate(const data::MultiHistogram& input, const ScalarView& grid)
{
real_t gridSpacing = grid(1) - grid(0);
real_t gridMin = grid(0) - 0.5_r * gridSpacing;
real_t gridMax = grid(grid.extent(0) - 1) + 0.5_r * gridSpacing;
auto h_grid = Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace(), grid);
real_t gridSpacing = h_grid(1) - h_grid(0);
real_t gridMin = h_grid(0) - 0.5_r * gridSpacing;
real_t gridMax = h_grid(h_grid.extent(0) - 1) + 0.5_r * gridSpacing;

data::MultiHistogram output(
"interpolated-profile", gridMin, gridMax, idx_c(grid.extent(0)), input.numHistograms);
"interpolated-profile", gridMin, gridMax, idx_c(h_grid.extent(0)), input.numHistograms);

MRMD_HOST_ASSERT_EQUAL(output.numBins, idx_c(grid.extent(0)), "Output grid size mismatch!");
MRMD_HOST_ASSERT_EQUAL(output.numBins, idx_c(h_grid.extent(0)), "Output grid size mismatch!");
for (idx_t idx = 0; idx < idx_c(output.numBins); ++idx)
{
MRMD_HOST_ASSERT_EQUAL(output.getBinPosition(idx), grid(idx), "Output grid mismatch!");
assert(assumption::isFloatEqual(output.getBinPosition(idx), h_grid(idx)));
}

auto policy = Kokkos::MDRangePolicy<Kokkos::Rank<2>>(
Expand Down