Week 3/wjdtkdgns #11
Open
Week 3/wjdtkdgns #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DongGeon0908
left a comment
DongGeon0908
left a comment
There was a problem hiding this comment.
웹소켓으로 작업해봐도 좋을 것 같아요.
- viewer의 수를 count해서 저장하는 로직도 같이요. (요거는 영구 데이터 저장이 필요할 듯 합니다.)
Comment on lines
+29
to
41
| implementation("org.springframework.boot:spring-boot-starter-data-jpa") | ||
| implementation("com.fasterxml.jackson.module:jackson-module-kotlin") | ||
| implementation("org.springdoc:springdoc-openapi-starter-webmvc-ui:2.0.0") | ||
| implementation("org.springdoc:springdoc-openapi-starter-webmvc-api:2.0.0") | ||
| implementation("org.springframework.boot:spring-boot-starter-data-redis") | ||
| runtimeOnly("com.mysql:mysql-connector-j") | ||
|
|
||
| testImplementation("org.springframework.boot:spring-boot-starter-test") | ||
| testImplementation("io.kotest:kotest-runner-junit5:5.7.2") | ||
| testImplementation("io.kotest:kotest-assertions-core:5.7.2") | ||
| testImplementation("io.kotest.extensions:kotest-extensions-spring:1.1.2") | ||
| testImplementation("io.mockk:mockk:1.13.8") | ||
| } |
| import org.springframework.data.repository.CrudRepository | ||
| import yapp.study.todolist.domain.viewer.entity.ViewerCount | ||
|
|
||
| interface ViewerCountRepository : CrudRepository<ViewerCount, Long> No newline at end of file |
Member
There was a problem hiding this comment.
JpaRepository를 사용하시지 않은 이유가 궁금해요
| private val viewerCountRepository: ViewerCountRepository, | ||
| private val viewerIdRepository: ViewerIdRepository | ||
| ) { | ||
| fun updateCount(increase: Boolean, id: Long) { |
Member
There was a problem hiding this comment.
구현해주신 로직은, 카운트 요청이 들어왔을 떄, 값을 올려주는 기능이네요.
Member
There was a problem hiding this comment.
이전에 말씀해주셨던 websocket을 적용해보는건 어때요?
DongGeon0908
requested changes
Nov 29, 2023
Member
DongGeon0908
left a comment
DongGeon0908
left a comment
There was a problem hiding this comment.
웹소켓으로 작업해봐도 좋을 것 같아요.
viewer의 수를 count해서 저장하는 로직도 같이요. (요거는 영구 데이터 저장이 필요할 듯 합니다.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewer 증가 했는데, 유저가 그냥 화면 꺼버리면 어떻게 처리해야할지 모르겠네요.....