Week 2/wjdtkdgns #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongGeon0908
requested changes
Nov 20, 2023
Member
DongGeon0908
left a comment
DongGeon0908
left a comment
There was a problem hiding this comment.
bulk update의 경우에는 log를 남겨주는 것도 좋을 것 같아요.
| testImplementation("io.kotest:kotest-runner-junit5:5.7.2") | ||
| testImplementation("io.kotest:kotest-assertions-core:5.7.2") | ||
| testImplementation("io.kotest.extensions:kotest-extensions-spring:1.1.2") | ||
| testImplementation("io.mockk:mockk:1.13.8") |
| package yapp.study.todolist.common.const | ||
|
|
||
| object TodoConst { | ||
| const val BULK_SIZE = 1000 |
|
|
||
| object TodoConst { | ||
| const val BULK_SIZE = 1000 | ||
| const val RESOURCES_PATH = "src/main/resources" |
| val status: Int, | ||
| val data: Any? | ||
| class SuccessResponse <T> ( | ||
| val data: T? |
Member
Author
There was a problem hiding this comment.
데이터가 반환될 필요가 없는 api 일 때 null 반환하도록 했어요
| else -> 200 | ||
| } | ||
| if (method == "POST") return 201 | ||
| return if (method == "DELETE") 204 else 200 |
Member
There was a problem hiding this comment.
만약 method가 delete인데, 반환값이 있는 경우에는 어떻게 할까요??
Member
Author
There was a problem hiding this comment.
status code 수정할 수 있도록 변경해볼게요
| fun toDto(todo: Todo, comments: List<CommentDto>): TodoCommentDto { | ||
| return TodoCommentDto( | ||
| id = todo.id, | ||
| id = todo.id!!, |
Comment on lines
+55
to
+56
| fun getCategoriesWithTodo(pageable: Pageable): PageResponse<CategoryWithTodosDto> { | ||
| val categorys = categoryRepository.findAll(pageable) |
Member
There was a problem hiding this comment.
카테고리를 페이징 처리하는게 뭔가,, 어색하게 느껴져요.
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(name = "comment_id") | ||
| val id: Long? = null, |
Member
There was a problem hiding this comment.
Suggested change
| val id: Long? = null, | |
| val id: Long = -1, |
| val commentRepository: CommentRepository, | ||
| val jdbcTemplate: JdbcTemplate | ||
| ) { | ||
| fun bulkInsert() { |
Member
There was a problem hiding this comment.
- 중도에 실패하는 경우, 기존에 insert처리된 로직은 어떻게 되는걸까요?
- 실패하는 경우, retry는 진행하지 않는 걸까요?
- 트랜잭션으로 묶이지 않은 이유가 궁금합니다.
Comment on lines
+85
to
+92
| try { | ||
| val fileReader = FileReader(File(path)) | ||
| val bufferReader = BufferedReader(fileReader) | ||
| return bufferReader.useLines { it.toList() } | ||
| } catch (e: IOException) { | ||
| println(e) | ||
| throw InternalServerException("i/o error") | ||
| } |
Member
There was a problem hiding this comment.
요기서 IO 부하를 줄이기 위해, 어떤 방식을 이용하면 좋을지 고민해 볼 필요가 있을 것 같아요.
Comment on lines
+31
to
+32
| println("bulk insert start") | ||
| println("category insert") |
Member
There was a problem hiding this comment.
log를 사용하는게 어떨까요?
현재는 console println이라서요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.