Use editorconfig here and autopatch apps projects#41
Use editorconfig here and autopatch apps projects#41fflorent wants to merge 3 commits intoYunoHost:mainfrom
Conversation
| spelling_language = fr | ||
|
|
||
| [**.yml] | ||
| indent_size = 2 |
There was a problem hiding this comment.
I found that yaml looks 2-spaces idented here. I follow what exists.
| # preserve client IP | ||
| proxy_set_header X-Forwarded-For $remote_addr; | ||
| # preserve client IP | ||
| proxy_set_header X-Forwarded-For $remote_addr; |
There was a problem hiding this comment.
Here is the tricky part.
nginx conf files seem to have 2-space indentation code style.
I don't know what to do with that: should it remain consistent with the rest of the files (4-spaces indentation) or should it be an exception (2-spaces)?
There was a problem hiding this comment.
In most of my apps I have 4 space indentation in nginx config so I suppose the nginx config indentation seem not really consistant. From my point of view we can make this consistent with the rest with 4 space and we can fix the place where it's not the case. But we might need the point of view from other packager.
There was a problem hiding this comment.
The less exceptions there are, the better for me. So OK for 4-space indentations in Nginx.
alexAubin
left a comment
alexAubin
left a comment
There was a problem hiding this comment.
LGTM but i'm thinking we should probably push this directly to all testing branches because it's a bit boring to have a PR for a straightforward change ?
|
@alexAubin How may we do that? (I don't have write access to all the repos) |
3 participants
As suggested by @Josue-T here: YunoHost/example_ynh#248 (comment)