Document optional sources flags (esp. in_subdir)#251
Open
CodeShakingSheep wants to merge 1 commit intoYunoHost:mainfrom
Open
Document optional sources flags (esp. in_subdir)#251CodeShakingSheep wants to merge 1 commit intoYunoHost:mainfrom
in_subdir)#251CodeShakingSheep wants to merge 1 commit intoYunoHost:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
From comments for sources in
manifest.tomlit's not clear thatin_subdiris set to true by default. A comment about that could have saved some good amount of troubleshooting (like in YunoHost-Apps/fossbilling_ynh#2) .Solution
Add respective comments.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)