Open
Conversation
Contributor
Author
|
@coredoesdev this replaces #829 - should be easier to read |
coredoesdev
requested changes
Dec 11, 2025
coredoesdev
requested changes
Dec 16, 2025
Fix bidding toggle logic and simplify buttons
iccowan
reviewed
Feb 10, 2026
Comment on lines
+14
to
+21
| public static function init() { | ||
| if (self::$initialized) { | ||
| return 1; | ||
| } | ||
| if (Storage::disk('local')->exists(self::FILENAME)) { | ||
| self::$data = Collection::fromJson(Storage::disk('local')->get(self::FILENAME)); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Do we have to set $initialized to true here? Or is that built into Laravel to do automatically?
Contributor
Author
There was a problem hiding this comment.
I'm not aware of a cleaner way to do this. Please let me know if you have a good trick.
iccowan
approved these changes
Feb 10, 2026
Member
iccowan
left a comment
iccowan
left a comment
There was a problem hiding this comment.
Looks good to me. Before merging, wait for @coredoesdev to give the thumbs up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will: